Skip to content

Fix FilterVarArrayDynamicReturnTypeExtension for mixed input#2338

Merged
ondrejmirtes merged 5 commits intophpstan:1.10.xfrom
zonuexe:fix/9178
Apr 12, 2023
Merged

Fix FilterVarArrayDynamicReturnTypeExtension for mixed input#2338
ondrejmirtes merged 5 commits intophpstan:1.10.xfrom
zonuexe:fix/9178

Conversation

@zonuexe
Copy link
Copy Markdown
Contributor

@zonuexe zonuexe commented Apr 12, 2023

@zonuexe zonuexe marked this pull request as draft April 12, 2023 18:16
@zonuexe zonuexe marked this pull request as ready for review April 12, 2023 18:16
@phpstan-bot
Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit 0a39cca into phpstan:1.10.x Apr 12, 2023
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you. I'll try to improve upon it.

@ondrejmirtes
Copy link
Copy Markdown
Member

It's hard for me to unpack everything that's going on in the extension, but I tried to make the code a bit nicer: cd1adfd

@zonuexe
Copy link
Copy Markdown
Contributor Author

zonuexe commented Apr 13, 2023

@ondrejmirtes Thanks a lot!

@zonuexe zonuexe deleted the fix/9178 branch April 13, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

filter_var_array with a mixed argument results in a fatal error

3 participants