Skip to content

Fix RecursiveIteratorIterator template type#228

Closed
simPod wants to merge 1 commit intophpstan:masterfrom
simPod:fix-template
Closed

Fix RecursiveIteratorIterator template type#228
simPod wants to merge 1 commit intophpstan:masterfrom
simPod:fix-template

Conversation

@simPod
Copy link
Copy Markdown
Contributor

@simPod simPod commented Jun 9, 2020

image

@ondrejmirtes
Copy link
Copy Markdown
Member

Unions aren’t supported yet. What real issues does the current stub cause?

@simPod
Copy link
Copy Markdown
Contributor Author

simPod commented Jun 9, 2020

Ah. It did not catch passing Traversable into RecursiveIteratorIterator.

https://phpstan.org/r/5e98305e-2a97-45bc-8447-3142a2e801fd

@ondrejmirtes
Copy link
Copy Markdown
Member

Can you open an issue (feature request) and show on 3v4l.org that it fails in PHP? Thanks.

@simPod
Copy link
Copy Markdown
Contributor Author

simPod commented Jun 9, 2020

Not sure what FR should I want 🤔

PHP failing example https://3v4l.org/evDe2

@ondrejmirtes
Copy link
Copy Markdown
Member

Just a normal "expected/actual output" kind of feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants