Check filter_input* type param type#2271
Merged
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom Apr 13, 2023
Merged
Conversation
Member
Contributor
what do you think about enabling these errors/use more precise signatures only when bleedingEdge and strict-rules are enabled? |
Contributor
Author
|
makes sense, thx for the inputs! I thought here it might be okay, because nobody ever should call these functions differently. I think it's a bit different compared to the linked PRs, but I get the general problem and point :) |
ondrejmirtes
requested changes
Apr 5, 2023
b91e872 to
8926e81
Compare
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
approved these changes
Apr 13, 2023
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying invalid ints there fails with a fatal error since PHP 8, see https://3v4l.org/2QvBP and https://3v4l.org/EP3T8
It would also be wrong on pre PHP 8 but there's no fatal error there at least.
This is the easiest I could come up with to check this, but it feels a bit weird. Any better ideas?
See also https://www.php.net/manual/en/function.filter-input.php and https://www.php.net/manual/en/function.filter-input-array.php
The 2 failing tests seem unrelated.
Some special handling based on PHP version could also be additionally built into e.g. #2010 (which can be merged I believe ;))