Skip testEditorUrlWithRelativePath() test on PHPStorm console#2229
Merged
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom Feb 8, 2023
Merged
Skip testEditorUrlWithRelativePath() test on PHPStorm console#2229ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
testEditorUrlWithRelativePath() test on PHPStorm console#2229ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
Conversation
ondrejmirtes
requested changes
Feb 8, 2023
| public function testEditorUrlWithRelativePath(): void | ||
| { | ||
| if ('JetBrains-JediTerm' === getenv('TERMINAL_EMULATOR')) { | ||
| $this->markTestSkipped('PHPStorm console does not support links in console.'); |
Member
There was a problem hiding this comment.
- I don't like yoda conditions
- It's
PhpStorm.
Contributor
Author
|
I verified this change makes the phpunit job run successfully on my machine. |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the only test which does not run successfully in the PHPStorm console.
see phpstan/phpstan#8854
I am not the only one with this problem, see #1927 (comment)