Support type narrowing with casted parameters#2186
Merged
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom Jan 17, 2023
Merged
Support type narrowing with casted parameters#2186ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
Conversation
5ce5fce to
c11e12f
Compare
c11e12f to
8f54f75
Compare
8f54f75 to
e3ce1ee
Compare
staabm
commented
Jan 17, 2023
| $unionType = TypeCombinator::union(...$types); | ||
| $specifiedTypes = $this->typeSpecifier->create($exprArg, $unionType, $context, false, $scope); | ||
|
|
||
| if ($context->true() && $exprArg instanceof Cast) { |
Contributor
Author
There was a problem hiding this comment.
my initial attempt was to do this directly within the TypeSpecifier ... but I then got the feeling that the type narrowing of a cast-expression is not a concept which can be applied to all specifying extensions.
Member
There was a problem hiding this comment.
Yeah, well, is_string((string) $int) is always true, but it doesn't make $int a string :D
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jan 17, 2023
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Also please test the negative context.
| $castOriginType = TypeCombinator::intersect($scope->getType($exprArg->expr), $unionType); | ||
|
|
||
| $specifiedTypes = $specifiedTypes->unionWith( | ||
| $this->typeSpecifier->create($exprArg->expr, $castOriginType, $context, false, $scope) |
Member
There was a problem hiding this comment.
Are you sure you can't just use $unionType instead of $castOriginType here in the 2nd arg?
Member
|
Thank you. |
1 similar comment
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#8714
https://3v4l.org/LPe72