Skip to content

Add missing @phpstan- prefixed tags#2177

Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
zonuexe:fix/phpstan-prefixed-phpdoc
Jan 12, 2023
Merged

Add missing @phpstan- prefixed tags#2177
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
zonuexe:fix/phpstan-prefixed-phpdoc

Conversation

@zonuexe
Copy link
Copy Markdown
Contributor

@zonuexe zonuexe commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test it in a separate method. So that we always see all the failures.

@ondrejmirtes
Copy link
Copy Markdown
Member

And FYI if you want this to be released much sooner, please base it on top of 1.9.x :)

@zonuexe zonuexe changed the base branch from 1.10.x to 1.9.x January 12, 2023 13:51
@ondrejmirtes ondrejmirtes merged commit 446ead7 into phpstan:1.9.x Jan 12, 2023
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@zonuexe zonuexe deleted the fix/phpstan-prefixed-phpdoc branch January 12, 2023 13:54
@ondrejmirtes
Copy link
Copy Markdown
Member

How sooner? This sooner :D https://github.com/phpstan/phpstan/releases/tag/1.9.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some implemented tags are warned as Unknown

2 participants