Remove redundant getType() calls in MutatingScope #2102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 13, 2022
| $exprVarType = $scope->getType($expr->var); | ||
| $dimType = $scope->getType($expr->dim); | ||
| $unsetType = $exprVarType->unsetOffset($dimType); | ||
| $exprVarNativeType = $scope->getType($expr->var); |
Contributor
Author
There was a problem hiding this comment.
I was wondering since these lines are the same as a few lines above. maybe it should instead be getNativeType instead of deleting the lines?
I tried both variants, but since all these variants did not regress any tests I went with the faster one.
//cc @rajyan
Contributor
There was a problem hiding this comment.
This was intended to use native type, not sure why this happened… Thanks for pointing it out.
I’ll fix them with regression test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.