This pull request has been marked as ready for review.

Thank you!

Sorry, I had to revert this, it's pretty annoying in practice. We first need to do a different feature in order for this one to be less annoying.

no problem. in case there is something I can do, please open a issue about the thing we need, so I can investigate.

The problem is that this now reports "always true" for the last elseif in an if-elseif-else blocks. In real-world projects this now reports dozens of new errors.

Also arguably last match arm shouldn't report this. Because people might prefer to write Foo::Bar => doFoo() instead of default => doFoo() to be notified when there's a new enum case to handle.

So, I have an idea: We need a new custom node visitor to mark the condition expression in last match arm and last elseif with an attribute. And ConstantConditionRuleHelper can use this node attribute to decide that "always true" shouldn't be reported there.

There's already an issue for this: phpstan/phpstan#8042

And after this is implemented, we can afford to report all "always true" conditions for everyone in bleedingEdge/2.0, not just phpstan-strict-rules users. Because the most annoying ones will not be reported anymore.