Cache resolved phpdoc in ClassReflection#2072
Merged
ondrejmirtes merged 1 commit intophpstan:1.9.xfrom Dec 10, 2022
Merged
Conversation
Member
|
Awesome, thank you! |
Contributor
|
Nice! 🎉 I somehow feel very peer-pressured to contribute to the performance improvements as well xD |
Contributor
Author
that was part of my dark plan behind the tweet.
|
Contributor
Author
|
@herndlm I think there is some potential in TypeTraverser but I have no idea yet on how we could get it faster
most called from
2nd most called from
|
Contributor
|
We should remove it 😁 |
Contributor
|
But jokes aside, there are a couple of misusages of it and I'll get rid of those. Most likely they are not affecting performance much.. |
Contributor
Author
|
Perf wise the only 2 relevant ones are these shown above. But the less the better design wise :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running
blackfire run php bin/phpstan -vvv --debugon my macleads to
