Maybe you can add some extra tests from this old pull request? 🤔 : #636

Maybe you can add some extra tests from this old pull request? 🤔 : #636

I take a look and there is only 6 check about array_key_exists and I feel like they already covered by the test:

if (array_key_exists($key, $b)) {
     assertType("'3'|'foo'", $key);
}

But I can add more tests if needed

Just rebased the branch if you have time to review @ondrejmirtes

To me the test failure are correct, cf #1941 (comment)

I'd like some more tests about tricky situations. Let's say we have an array shape like:

$a = [3 => 'foo', 4 => 'bar']

When we have string $key and we ask about array_key_exists($key, $a), the $key should become '3'|'4'.

It should work generally, so int|string should become 3|4|'3'|'4'.

Test added with a little fix to get the expected behavior

For the build failure:
https://github.com/phpstan/phpstan-src/actions/runs/3869539129/jobs/6595709562

/**
     * Apply filters to address query builder.
     *
     * @param array $filters
     * @param QueryBuilder $qb
     */
    private function applyFilters(QueryBuilder $qb, array $filters)
    {
        $allowedFiltersMap = [
            'id_customer' => 'a.id_customer',
        ];

        foreach ($filters as $filterName => $value) {
            if (!array_key_exists($filterName, $allowedFiltersMap) || empty($value)) {
                continue;
            }

            if ('id_customer' === $filterName) {
                $qb->andWhere('a.`id_customer` = :' . $filterName);
                $qb->setParameter($filterName, $value);

                continue;
            }

            $qb->andWhere($allowedFiltersMap[$filterName] . ' LIKE :' . $filterName)
                ->setParameter($filterName, '%' . $value . '%');
        }
    }

The end of the foreach is indeed never reach, because of the array_key_exists check, the only $filterName value allowed is 'id_customer' which is handled by the following if.

https://github.com/phpstan/phpstan-src/actions/runs/3869539129/jobs/6595709711

if (array_key_exists($join['joinAlias'], $knownAliases)) {
    throw QueryException::nonUniqueAlias($join['joinAlias'], array_keys($knownAliases));
}

The fact is in the doctrine code, we are inside a foreach, and we're modifying $knowAliases by setting new value with keys that are mixed, so the initial array<string, mixed> array become array<int|string, mixed>. Therefor the new error reported by PHPStan is correct too.

@ondrejmirtes Do I need to target 1.10.x now ?

@VincentLanglet No #2043 (comment)

Thank you.