Upgrade deprecated set-*#1917
Conversation
|
@ondrejmirtes https://github.com/rez1dent3/phpstan-src/actions/runs/3322894879/jobs/5492570187 |
|
This pull request has been marked as ready for review. |
|
This solved my problem, you shouldn't have any more problems either. https://github.com/rez1dent3/ghacts/pull/1#issuecomment-1291092461 |
|
Thank you very much! |
|
Hey @rez1dent3 it looks like you know your stuff when it comes to Bash. Could you please help me out a bit? It's about this line: phpstan-src/.github/workflows/phar.yml Line 243 in 34dabdd When the Git log contains a commit that contains message with The failure is: |
git commit --gpg-sign -m "Updated PHPStan to commit e16c1df489c7002e9e4609ee4f3490ed70d13814" -m "https://github.com/phpstan/phpstan-src/commit/e16c1df489c7002e9e4609ee4f3490ed70d13814 Revert \"Improve expression type resolving of superglobals\"" --author "Ondrej Mirtes <ondrej@mirtes.cz>"Hello. The line escaping is missing. At least I think so. |
|
I'll try to make a fix in my free time. |
|
Surprisingly newlines work correctly if you look at some examples of commits here phpstan/phpstan@7380ed0. What doesn't work are double quotes. Bash is really mysterious to me here. If I had a variable then |
|
Isn't it that the unescaped double quotes inside the double quotes end the string / arg leading to the following things being interpreted as new args / commands. Or am I oversimplifying this? |
|
It is but I don't know what to do about it. |
|
Ah OK, the dynamic part with github actions replacament, got it. I also wonder if there is a better solution than trying to string replace it or use something like https://unix.stackexchange.com/questions/379181/escape-a-variable-for-use-as-content-of-another-script which would need the string to be assigned to a a variable I suppose. Looking forward to the solution :) |
Second try #1910...
@ondrejmirtes Hello. I'm not sure that there will be a correct log (log escaping). Unfortunately, I can't check it in my fork. At least there is no more error: https://github.com/rez1dent3/phpstan-src/actions/runs/3322690041/jobs/5492131881