Skip to content

Improve wording of the NonexistentOffset, BooleanAndConstantConditionRule and BooleanOrConstantConditionRule#1882

Merged
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
VincentLanglet:wording
Oct 25, 2022
Merged

Improve wording of the NonexistentOffset, BooleanAndConstantConditionRule and BooleanOrConstantConditionRule#1882
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
VincentLanglet:wording

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Oct 20, 2022 •
edited
Loading

Related to phpstan/phpstan#8187 (comment)

I feel like

Offset 'c' does not exist on array{c?: int}.

is confusing and

Offset 'c' might not exist on array{c?: int}.

is better.

@VincentLanglet VincentLanglet marked this pull request as ready for review October 20, 2022 22:23
@phpstan-bot
Copy link
Collaborator

phpstan-bot commented Oct 20, 2022

This pull request has been marked as ready for review.

@VincentLanglet VincentLanglet mentioned this pull request Oct 20, 2022
Closed
ondrejmirtes
ondrejmirtes requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this because it'd break existing baselines. We can do this only with a new bleedingEdge toggle.

A similar thing could be fixed in BooleanAndConstantConditionRule and BooleanOrConstantConditionRule where the message still uses && and || even for logical and and or operators.

@herndlm
Copy link
Contributor

herndlm commented Oct 21, 2022

new bleeding edge toggle kind of means that it will get into the next major automatically, right?
sounds like a good solution then, otherwise it would need to be remembered / noted down :)

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 21, 2022

Exactly, and no rebase nightmare either.

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Oct 21, 2022

Yeah, I'll update the PR

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Oct 22, 2022

We can't do this because it'd break existing baselines. We can do this only with a new bleedingEdge toggle.

Done

A similar thing could be fixed in BooleanAndConstantConditionRule and BooleanOrConstantConditionRule where the message still uses && and || even for logical and and or operators.

Done

@VincentLanglet VincentLanglet changed the title Improve wording of the NonexistenOffset error Improve wording of the NonexistenOffset, BooleanAndConstantConditionRule and BooleanOrConstantConditionRule error Oct 22, 2022
@ondrejmirtes ondrejmirtes changed the title Improve wording of the NonexistenOffset, BooleanAndConstantConditionRule and BooleanOrConstantConditionRule error Improve wording of the NonexistentOffset, BooleanAndConstantConditionRule and BooleanOrConstantConditionRule Oct 25, 2022
@ondrejmirtes ondrejmirtes merged commit d2227f8 into phpstan:1.9.x Oct 25, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 25, 2022

Thank you.

@VincentLanglet VincentLanglet deleted the wording branch October 25, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VincentLanglet @phpstan-bot @herndlm @ondrejmirtes