Performance improvements #1830
Closed
Performance improvements #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd12a13 to
c4268c0
Compare
Contributor
|
with the many type related cleanups I do on 1.9.x we need to be careful to not cause conflicts if bigger type changes are made on 1.8.x still :) |
Contributor
Author
|
I can just point this at 1.9.x of course, though the merge looked relatively clean locally :) |
c4268c0 to
aa7b1ea
Compare
Member
|
I rebased this, but the performance issue in the new test doesn't go away :/ |
Member
|
This is probably a dead end :) We already optimized 8146, mainly by dumbing down the arrays again, and be a bit more forgiving with oversized arrays in type checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some perf improvements (mostly related to constant arrays) implemented while investigating phpstan/phpstan#8146.