declare more precise getClass* return types#1754
Merged
ondrejmirtes merged 4 commits intophpstan:2.0.xfrom Sep 30, 2024
Merged
Conversation
d2e0929 to
78f4c94
Compare
ondrejmirtes
requested changes
Sep 24, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
I'd agree with extensions but not with ObjectType/TypeWithClassName. That's used to represent invalid class names too.
Member
|
Yeah, still a BC break, we have to wait for 2.0 if we find it valuable. |
Contributor
Author
|
agree. thx for the review. |
Contributor
Author
|
what do you think about adding these PRs to a separate milestone, so they won't be forgotten when we do the next major version? |
Member
|
That's not necessary, I've got a private todolist with 50 items already, it's not gonna get lost. |
91cbea6 to
c8d4b52
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.