Preserve non-empty-array type when generalizing arrays with incompatible keys #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30c29fc to
f162d34
Compare
Contributor
Author
|
oh I might have messed up here with the rebase. I wanted to see a green pipeline again :) |
Member
|
Thank you! |
Member
|
BTW please still use 1.8.x for bugfixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7996
Extracted from #1732, there's no need for this dependency. Also @rvanvelzen is doing the same thing for the list in his new PR which is another reason for me to extract it :)
Update: changed the commit message. The incompatible key part is misleading