Improve TypeCombinator::reduceArrays() perf with retained type compleness
#1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab2ecc4 to
3e4e59e
Compare
TypeCombinator::reduceArrays() perf with retained type compleness
rvanvelzen
commented
Sep 22, 2022
3e4e59e to
c5729cc
Compare
Member
Contributor
Author
|
I already updated #1666 to remove your optimization. As you noted there it's the same thing but a bit more aggressive. |
Member
|
I see, I didn't notice that. I'll merge it right away :) |
Member
|
Just merged it. |
Contributor
|
the array improvements are strong today 💪 |
a0d4c85 to
c78f2cf
Compare
c78f2cf to
0dbbbf2
Compare
0dbbbf2 to
637a0ee
Compare
Member
|
This is green now 🎉 |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for phpstan/phpstan#7666. This sort-of depends on #1666 (or a similar solution) to keep arrays with many
HasOffsetValueTypes more compact, which now do suffer from a perf loss.The complex test cases that this mostly covers have become a bit slower, but still very manageable.