Skip to content

Fix checking empty constant arrays in array_pop and array_shift extensions #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Sep 8, 2022
Merged

Fix checking empty constant arrays in array_pop and array_shift extensions #1712

ondrejmirtes merged 1 commit into from
Sep 8, 2022

Conversation

@herndlm
Copy link
Contributor

@herndlm herndlm commented Sep 8, 2022

@herndlm herndlm marked this pull request as ready for review September 8, 2022 10:34
cs278
cs278 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@cs278 cs278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ondrejmirtes ondrejmirtes merged commit fb08fb5 into phpstan:1.8.x Sep 8, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 8, 2022

Thank you!

@herndlm herndlm deleted the fix-7968 branch September 9, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cs278 cs278 cs278 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

array_shift() regression with some arrays

3 participants

@herndlm @ondrejmirtes @cs278