Skip to content

Fix specifying types for left side of null coalesce #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
Sep 6, 2022
Merged

Fix specifying types for left side of null coalesce #1707

ondrejmirtes merged 1 commit into from
Sep 6, 2022

Conversation

@rvanvelzen
Copy link
Contributor

@rvanvelzen rvanvelzen commented Sep 6, 2022

ondrejmirtes
ondrejmirtes requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Would you try deleting the if about Coalesce in TypeSpecifier on line 971 to see if it's still needed?
  2. Shouldn't this somehow work recursively even for $foo ?? $bar ?? $baz?

@rvanvelzen
Copy link
Contributor Author

rvanvelzen commented Sep 6, 2022 •
edited
Loading

  1. Would you try deleting the if about Coalesce in TypeSpecifier on line 971 to see if it's still needed?

The bug-560 test fails without it

  1. Shouldn't this somehow work recursively even for $foo ?? $bar ?? $baz?

Without thinking too much about it it might, but I'd rather approach that separately - I haven't seen that kind of type narrowing in actual code before.

@rvanvelzen rvanvelzen force-pushed the type-specify-coalesce branch from 0c261d3 to 48e3ee2 Compare September 6, 2022 15:27
@rvanvelzen
Copy link
Contributor Author

rvanvelzen commented Sep 6, 2022

The test failure is unrelated as far as I can tell - broken by laravel/framework@d44c345

@rvanvelzen rvanvelzen marked this pull request as ready for review September 6, 2022 15:44
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 6, 2022

I agree, thank you very much 😊

@ondrejmirtes ondrejmirtes merged commit 0bfc5eb into phpstan:1.8.x Sep 6, 2022
@rvanvelzen rvanvelzen deleted the type-specify-coalesce branch September 7, 2022 04:50
@rajyan rajyan mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@rvanvelzen @ondrejmirtes