Skip to content

update nikic/php-parser to 4.15.0#1690

Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
staabm:parser-up
Sep 4, 2022
Merged

update nikic/php-parser to 4.15.0#1690
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
staabm:parser-up

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Sep 4, 2022

}
}

// serialize/unserialize is not considered a magic method by PhpParser
Copy link
Copy Markdown
Contributor Author

@staabm staabm Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer required, as php-parser itself handles this methods as magic.

see changelog

Added __serialize and __unserialize to magic method list.

@staabm staabm marked this pull request as ready for review September 4, 2022 06:05
@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Sep 4, 2022

btw: the new drupal integration test seems to be pretty slow in comparison to other integration test runs. I will have a closer look on that (unrelated to this PR)

@ondrejmirtes
Copy link
Copy Markdown
Member

Yes, I want to optimize that. I also need to look into DNF types and implement them in BetterReflection.

@ondrejmirtes ondrejmirtes merged commit 3225f1a into phpstan:1.8.x Sep 4, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@staabm staabm deleted the parser-up branch September 4, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants