Skip to content

Use TypeUtils::getOldConstantArrays in array pointer functions extension#1678

Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
herndlm:array-pointer-functions-get-old-constant-arrays
Sep 1, 2022
Merged

Use TypeUtils::getOldConstantArrays in array pointer functions extension#1678
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
herndlm:array-pointer-functions-get-old-constant-arrays

Conversation

@herndlm
Copy link
Copy Markdown
Contributor

@herndlm herndlm commented Sep 1, 2022

I noticed that this is fixing the same optional key edge cases as #1668 did, but for reset and end

@herndlm herndlm marked this pull request as ready for review September 1, 2022 09:34
@ondrejmirtes ondrejmirtes merged commit f249159 into phpstan:1.8.x Sep 1, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@herndlm herndlm deleted the array-pointer-functions-get-old-constant-arrays branch September 1, 2022 09:36
@staabm
Copy link
Copy Markdown
Contributor

staabm commented Sep 1, 2022

@herndlm is on fire :-)

great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants