Or, other idea: maybe I should further debug why never + 1 apparently leads to a float? If that would lead to never I don't need this extra if block if I also use isString() instead I guess.

UPDATE: found it, it comes from InitializerExprTypeResolver::resolveCommonMath. I think fixing common math operations with a NeverType makes more sense then. Will add another commit.

Just guesswork: maybe you could use toNumber Beforehand?

Just guesswork: maybe you could use toNumber Beforehand?

phpstan-src/src/Type/Type.php

Line 87 in 32353a9

public function toNumber(): Type;

it would still stay being the NeverType, which makes sense. But this info is lost in InitializerExprTypeResolver when dealing with common math and is simply transformed to a float which does not make sense to me. I'm currently adapting it to lead to a NeverType, as also does the ErrorType. That makes at least sense to me, but let's see :)

Hmm did only see that one new pmmp error now. Coming from https://github.com/pmmp/PocketMine-MP/blob/e0b07ff3087b652407439a29c941f3b66ca92c86/src/pocketmine/utils/Utils.php#L480

I cannot comprehend this now, need to check it though

The pmmp types before the loop did not change, also according to https://phpstan.org/r/a0ce70a0-43ad-4324-8113-4eda1914b536 the loop is basically dead if I read the types and ranges right. I think I didn't break anything related to this but rather unhid a pmmp error or a phpstan bug.

I'm not entirely sure if this loop is dead code or not, but at least I can't also simply trigger it via e.g. https://3v4l.org/DaGfU

//cc @dktapps

I think you should add a explicit never + 1 test

I've no idea how that code works. @SOF3 can you shed any light on this?

jfyi it looks close to some other java string hash functions that can be found online, e.g. https://github.com/openjdk/jdk/blob/jdk-20+11/src/java.base/share/classes/java/lang/StringUTF16.java#L414 but with additional things going on :)

Thank you!

jfyi it looks close to some other java string hash functions that can be found online, e.g. https://github.com/openjdk/jdk/blob/jdk-20+11/src/java.base/share/classes/java/lang/StringUTF16.java#L414 but with additional things going on :)

Thanks. Looks like some overengineering going on here, probably to prevent overflowing into a float.