Skip to content

Replace pickArrays method in array_search extension with getAnyArrays helper#1632

Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
herndlm:array-search-cleanup
Aug 19, 2022
Merged

Replace pickArrays method in array_search extension with getAnyArrays helper#1632
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
herndlm:array-search-cleanup

Conversation

@herndlm
Copy link
Copy Markdown
Contributor

@herndlm herndlm commented Aug 18, 2022

just a tiny cleanup. I think there should be enough legacy node scope resolver tests to cover this

UPDATE: added a second cleanup commit that would only cause a conflict in a dedicated branch..

@herndlm herndlm force-pushed the array-search-cleanup branch from f783d81 to e39ec15 Compare August 18, 2022 13:40
@herndlm herndlm marked this pull request as ready for review August 18, 2022 13:50
@herndlm herndlm marked this pull request as draft August 18, 2022 14:21
@herndlm herndlm marked this pull request as ready for review August 18, 2022 14:35
@ondrejmirtes ondrejmirtes merged commit 6113164 into phpstan:1.8.x Aug 19, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@herndlm herndlm deleted the array-search-cleanup branch October 13, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants