Skip to content

sscanf: allow nulls in returned array#1577

Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
staabm:sscanf
Aug 25, 2022
Merged

sscanf: allow nulls in returned array#1577
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
staabm:sscanf

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Aug 1, 2022

@staabm staabm marked this pull request as ready for review August 1, 2022 13:41
@ondrejmirtes ondrejmirtes merged commit e722017 into phpstan:1.8.x Aug 25, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@staabm staabm deleted the sscanf branch August 25, 2022 13:18
@ondrejmirtes
Copy link
Copy Markdown
Member

@staabm Please fix tests on 1.8.x, I didn't check before rebasing and there were some conflicting asserts.

@herndlm herndlm mentioned this pull request Aug 25, 2022
@herndlm
Copy link
Copy Markdown
Contributor

herndlm commented Aug 25, 2022

@staabm Please fix tests on 1.8.x, I didn't check before rebasing and there were some conflicting asserts.

noticed them as well when I rebased my PR :) #1652

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Aug 25, 2022

Thank you guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sscanf can return nulls

3 participants