Added stub files and tests for array_* functions.#1571
Closed
mad-briller wants to merge 1 commit intophpstan:1.8.xfrom
Closed
Added stub files and tests for array_* functions.#1571mad-briller wants to merge 1 commit intophpstan:1.8.xfrom
mad-briller wants to merge 1 commit intophpstan:1.8.xfrom
Conversation
array_diff_uassoc array_diff_ukey array_intersect_uassoc array_intersect_ukey array_udiff_assoc array_udiff_uassoc array_uintersect_assoc array_uintersect_uassoc array_uintersect
ondrejmirtes
requested changes
Jul 30, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
The TK templates should have array-key bounds instead of mixed.
Contributor
Author
|
i tried that but it seemed to break the templating by using when using |
Member
|
Please push the stubs with |
Member
|
Feel free to open a new PR if you decide to finish it, thank you :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#7707
functions stubbed:
array_diff_uassoc
array_diff_ukey
array_intersect_uassoc
array_intersect_ukey
array_udiff_assoc
array_udiff_uassoc
array_uintersect_assoc
array_uintersect_uassoc
array_uintersect
whilst adding these, phpstan warned because i didn't add array iterable types for the returns so i've specified them in the stubs, however i noticed this return type extension plugin which seems to be overriding them anyway, if theres something i should do instead let me know