Add non regression test for bug 5232#1557
Merged
ondrejmirtes merged 3 commits intophpstan:1.8.xfrom Jul 26, 2022
Merged
Conversation
ondrejmirtes
requested changes
Jul 26, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
I haven't written this one yet, so you can do that :)
This should be a test for ReturnTypeRuleTest. I reserve AnalyserIntegrationTest.php for things that crash PHPStan or for bad performance problems.
ondrejmirtes
requested changes
Jul 26, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
This test would never fail, you should check that by cherrypicking it on top of 1.8.x before the yesterday's fixes 😊
A hint: there are two ReturnTypeRuleTest classes.
Contributor
Author
Indeed, I always confuse method and functions... Should be better now |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#5232