Fix ObjectType resolving inside bound Closure#1543
Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom Jul 24, 2022
Merged
Fix ObjectType resolving inside bound Closure#1543ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom
Conversation
Contributor
Author
|
hmm I see the same 3 failures (with more errors) in the non-falsy-string PR, so they should be unrelated 🤞 but this needs to be double-checked and I have actually no clue where the came from (weren't there still a couple of days ago?).. |
herndlm
commented
Jul 24, 2022
Member
|
Thank you! |
1 similar comment
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7675
This is my first time dealing with this dynamic Closure binding, but I guess this make sense. Previously it would lead incorrectly to a
ThisTypebecause$originalClass === $this->getClassReflection()->getName()evaluates to true if$originalClassis the one where the Closure bind is in.