Fix #7531 - "Unreachable statement" false positive for html whitespace#1497
Closed
murilohpucci wants to merge 2 commits intophpstan:1.8.xfrom
Closed
Fix #7531 - "Unreachable statement" false positive for html whitespace#1497murilohpucci wants to merge 2 commits intophpstan:1.8.xfrom
murilohpucci wants to merge 2 commits intophpstan:1.8.xfrom
Conversation
Contributor
|
You should add a test with non-whitespace html as well, to make sure that that is reported. |
Author
I hope I got it right, I've just added one more test scenario where there's non-whitespaces, and in this case it's expected to not be reported by phpstan |
Contributor
|
Sorry, I guess that was a bit ambiguous. I avtually meant non-whitespace and non-empty, because that should be reported :) |
Member
|
@murilohpucci Would be nice if you were able to finish this PR :) |
cc0d17d to
e0cd35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, first time here, I hope this can help you.
Fixing: #7531