Do not ignore traits in ClassStatementsGatherer #1339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm suprised that only one run failed, but I get how annoying this can be. I have a better idea that should give us the best of both worlds. I'll look into that later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sense IMO since traits can be seen as copy/paste helpers, but most-likely I'm missing the reason why they were ignored there in the first place. To not be too annoying maybe with generic traits and multiple private helper methods and so? Mostly I want to find out what CI thinks about this..
This would also be the basis to fix
ClassPropertiesNode::getUninitializedPropertiesby including trait props too, which in term fixes various trait-related readonly / uninitialized property rules.