Make the type signatures of some hash functions more specific#1224
Merged
Conversation
The following hash functions cannot return an empty string, but had `string` return type signature before: - `crypt` - `password_hash` - `sha1` - `sha1_file` Those function now are marked as returning `non-empty-string`s. Fixes phpstan/phpstan#7051
Member
|
Thank you! |
Contributor
Author
|
You're welcome! (And Happy Easter!) 🥚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following hash functions cannot return an empty string, but
had
stringreturn type signature before:cryptpassword_hashsha1sha1_fileThose function now are marked as returning
non-empty-strings.Fixes phpstan/phpstan#7051