Skip to content

Add return type extension for mb_strlen#1211

Merged
ondrejmirtes merged 10 commits into
phpstan:1.5.xfrom
fluffycondor:mb-strlen-return-type-extension
Apr 21, 2022
Merged

Add return type extension for mb_strlen#1211
ondrejmirtes merged 10 commits into
phpstan:1.5.xfrom
fluffycondor:mb-strlen-return-type-extension

Conversation

@fluffycondor

@fluffycondor fluffycondor commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

Now it evaluates mb_strlen return value also based on the first passed argument.

Comment thread tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php Outdated
Comment thread tests/PHPStan/Analyser/data/functions.php Outdated
@fluffycondor

fluffycondor commented Apr 20, 2022

Copy link
Copy Markdown
Contributor Author

Whoops, looks like I have 10 failed checks after rebasing 1.5.x into my branch.
Does 1.5.x pass these checks?

@herndlm

herndlm commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Whoops, looks like I have 10 failed checks after rebasing 1.5.x into my branch. Does 1.5.x pass these checks?

phpstan-symfony currently is failing on 1.5.x, that would be expected :)

@ondrejmirtes ondrejmirtes merged commit c19a822 into phpstan:1.5.x Apr 21, 2022
@ondrejmirtes

Copy link
Copy Markdown
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants