Add curl_getinfo dynamic return type extension #1072
Conversation
|
When you use https://github.com/phpstan/phpstan-src/blob/1.5.x/tests/PHPStan/Analyser/NodeScopeResolverTest.php for testing instead of the Legacy test-class, you can add separate test files per php-version, so you don‘t need to limit this feature on constants available on all versions |
|
@staabm Thanks for the fast review and all the help so far! I will finalize the tests tomorrow! |
staabm
left a comment
There was a problem hiding this comment.
great job so far.
for a few days there is also a 1.4.x branch.. I think this PR should target that branch instead of the longer termin 1.5.x
…and add php version specific tests
…ception and process further feedback
…early here but that makes the test less maintainable
… on base Type class
|
@staabm Thanks! I rebased on 1.4.x, moved the tests to the non-legacy test cases and processed the rest of the feedback. Can you give me some pointers to fix the remaining 2 checks? |
|
From my perspective this looks good, thank you. we need to double check the errors in https://github.com/phpstan/phpstan-src/runs/5559798589?check_suite_focus=true otherwise - lets wait for some feedback from ondrey |
…rn the correct type
|
Thank you! I merged it in 1.5.x: ef59f08 |
|
FYI I checked PHP docs and concluded that the keys are not optional: 9cde413 |
No description provided.