Skip to content

Update the signature for set_error_handler() #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 2 commits into from
Feb 10, 2022
Merged

Update the signature for set_error_handler() #1008

ondrejmirtes merged 2 commits into from
Feb 10, 2022

Conversation

@johnbillion
Copy link
Contributor

@johnbillion johnbillion commented Feb 9, 2022 •
edited
Loading

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Feb 9, 2022

This is totally fine if CI passes. (There are currently two integration projects that fail on master, you can disregard those).

@johnbillion johnbillion marked this pull request as ready for review February 9, 2022 20:33
@ondrejmirtes ondrejmirtes merged commit bd78291 into phpstan:master Feb 10, 2022
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Feb 10, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect signature for the set_error_handler() callback in PHP >= 8

2 participants

@johnbillion @ondrejmirtes