Default value property type does not observe strict types - it's always strict

ondrejmirtes · ondrejmirtes · commit fe72e26195eb · 2020-06-07T10:15:19.000+02:00
diff --git a/src/Rules/Properties/DefaultValueTypesAssignedToPropertiesRule.php b/src/Rules/Properties/DefaultValueTypesAssignedToPropertiesRule.php
@@ -50,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array
 				}
 			}
 			$defaultValueType = $scope->getType($property->default);
-			if ($this->ruleLevelHelper->accepts($propertyType, $defaultValueType, $scope->isDeclareStrictTypes())) {
+			if ($this->ruleLevelHelper->accepts($propertyType, $defaultValueType, true)) {
 				continue;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`	`$defaultValueType = $scope->getType($property->default);`
`53`		`- if ($this->ruleLevelHelper->accepts($propertyType, $defaultValueType, $scope->isDeclareStrictTypes())) {`
	`53`	`+ if ($this->ruleLevelHelper->accepts($propertyType, $defaultValueType, true)) {`
`54`	`54`	`continue;`
`55`	`55`	`}`
`56`	`56`