Cache pretty printed expression

lookyman · ondrejmirtes · commit faadcf412dc3 · 2020-01-05T17:53:10.000+01:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -378,7 +378,13 @@ public function getAnonymousFunctionReturnType(): ?\PHPStan\Type\Type
 
 	public function getType(Expr $node): Type
 	{
-		$key = $this->printer->prettyPrintExpr($node);
+		/** @var string|null $key */
+		$key = $node->getAttribute('phpstan_cache_printer');
+		if ($key === null) {
+			$key = $this->printer->prettyPrintExpr($node);
+			$node->setAttribute('phpstan_cache_printer', $key);
+		}
+
 		if (!array_key_exists($key, $this->resolvedTypes)) {
 			$this->resolvedTypes[$key] = $this->resolveType($node);
 		}

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,13 @@ public function getAnonymousFunctionReturnType(): ?\PHPStan\Type\Type`
`378`	`378`
`379`	`379`	`public function getType(Expr $node): Type`
`380`	`380`	`{`
`381`		`- $key = $this->printer->prettyPrintExpr($node);`
	`381`	`+ /** @var string\|null $key */`
	`382`	`+ $key = $node->getAttribute('phpstan_cache_printer');`
	`383`	`+ if ($key === null) {`
	`384`	`+ $key = $this->printer->prettyPrintExpr($node);`
	`385`	`+ $node->setAttribute('phpstan_cache_printer', $key);`
	`386`	`+ }`
	`387`	`+`
`382`	`388`	`if (!array_key_exists($key, $this->resolvedTypes)) {`
`383`	`389`	`$this->resolvedTypes[$key] = $this->resolveType($node);`
`384`	`390`	`}`