InFunctionNode always contains PhpFunctionFromParserNodeReflection

ondrejmirtes · ondrejmirtes · commit e864b24a854a · 2023-01-25T17:20:30.000+01:00
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -118,6 +118,7 @@
 use PHPStan\Reflection\ParameterReflectionWithPhpDocs;
 use PHPStan\Reflection\ParametersAcceptor;
 use PHPStan\Reflection\ParametersAcceptorSelector;
+use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
 use PHPStan\Reflection\Php\PhpMethodReflection;
 use PHPStan\Reflection\ReflectionProvider;
@@ -443,7 +444,7 @@ private function processStmtNode(
 				$phpDocParameterOutTypes,
 			);
 			$functionReflection = $functionScope->getFunction();
-			if (!$functionReflection instanceof FunctionReflection) {
+			if (!$functionReflection instanceof PhpFunctionFromParserNodeReflection) {
 				throw new ShouldNotHappenException();
 			}
 
diff --git a/src/Node/InFunctionNode.php b/src/Node/InFunctionNode.php
@@ -3,21 +3,21 @@
 namespace PHPStan\Node;
 
 use PhpParser\Node;
-use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 
 /** @api */
 class InFunctionNode extends Node\Stmt implements VirtualNode
 {
 
 	public function __construct(
-		private FunctionReflection $functionReflection,
+		private PhpFunctionFromParserNodeReflection $functionReflection,
 		private Node\Stmt\Function_ $originalNode,
 	)
 	{
 		parent::__construct($originalNode->getAttributes());
 	}
 
-	public function getFunctionReflection(): FunctionReflection
+	public function getFunctionReflection(): PhpFunctionFromParserNodeReflection
 	{
 		return $this->functionReflection;
 	}

Original file line number	Diff line number	Diff line change
`@@ -3,21 +3,21 @@`
`3`	`3`	`namespace PHPStan\Node;`
`4`	`4`
`5`	`5`	`use PhpParser\Node;`
`6`		`-use PHPStan\Reflection\FunctionReflection;`
	`6`	`+use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;`
`7`	`7`
`8`	`8`	`/** @api */`
`9`	`9`	`class InFunctionNode extends Node\Stmt implements VirtualNode`
`10`	`10`	`{`
`11`	`11`
`12`	`12`	`public function __construct(`
`13`		`- private FunctionReflection $functionReflection,`
	`13`	`+ private PhpFunctionFromParserNodeReflection $functionReflection,`
`14`	`14`	`private Node\Stmt\Function_ $originalNode,`
`15`	`15`	`)`
`16`	`16`	`{`
`17`	`17`	`parent::__construct($originalNode->getAttributes());`
`18`	`18`	`}`
`19`	`19`
`20`		`- public function getFunctionReflection(): FunctionReflection`
	`20`	`+ public function getFunctionReflection(): PhpFunctionFromParserNodeReflection`
`21`	`21`	`{`
`22`	`22`	`return $this->functionReflection;`
`23`	`23`	`}`