RuleLevelHelper - consider trait as an unknown class

ondrejmirtes · ondrejmirtes · commit e089754fca00 · 2020-03-16T13:05:38.000+01:00
diff --git a/src/Rules/RuleLevelHelper.php b/src/Rules/RuleLevelHelper.php
@@ -172,7 +172,10 @@ public function findTypeToCheck(
 		$directClassNames = TypeUtils::getDirectClassNames($type);
 		foreach ($directClassNames as $referencedClass) {
 			if ($this->reflectionProvider->hasClass($referencedClass)) {
-				continue;
+				$classReflection = $this->reflectionProvider->getClass($referencedClass);
+				if (!$classReflection->isTrait()) {
+					continue;
+				}
 			}
 
 			$errors[] = RuleErrorBuilder::message(sprintf($unknownClassErrorPattern, $referencedClass))->line($var->getLine())->build();
diff --git a/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php
@@ -220,6 +220,10 @@ public function testCallStaticMethods(): void
 				'Call to static method doFoo() on trait CallStaticMethods\TraitWithStaticMethod.',
 				323,
 			],
+			[
+				'Call to static method doFoo() on an unknown class CallStaticMethods\TraitWithStaticMethod.',
+				328,
+			],
 		]);
 	}
 
diff --git a/tests/PHPStan/Rules/Methods/data/call-static-methods.php b/tests/PHPStan/Rules/Methods/data/call-static-methods.php
@@ -323,4 +323,9 @@ public function doFoo(): void
 		TraitWithStaticMethod::doFoo();
 	}
 
+	public function doBar(TraitWithStaticMethod $a): void
+	{
+		$a::doFoo();
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -323,4 +323,9 @@ public function doFoo(): void`
`323`	`323`	`TraitWithStaticMethod::doFoo();`
`324`	`324`	`}`
`325`	`325`
	`326`	`+ public function doBar(TraitWithStaticMethod $a): void`
	`327`	`+ {`
	`328`	`+ $a::doFoo();`
	`329`	`+ }`
	`330`	`+`
`326`	`331`	`}`