Fix unknown constants as default parameter values

ondrejmirtes · ondrejmirtes · commit d3044eef82ab · 2020-08-02T15:19:04.000+02:00
diff --git a/composer.json b/composer.json
@@ -21,7 +21,7 @@
 		"nette/utils": "dev-master as 3.1.99",
 		"nikic/php-parser": "4.7.0",
 		"ondram/ci-detector": "^3.4.0",
-		"ondrejmirtes/better-reflection": "4.3.21",
+		"ondrejmirtes/better-reflection": "4.3.22",
 		"phpdocumentor/reflection-docblock": "4.3.4",
 		"phpstan/phpdoc-parser": "^0.4.8",
 		"react/child-process": "^0.6.1",
diff --git a/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php b/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php
@@ -342,4 +342,13 @@ public function testBug3478(): void
 		$this->analyse([__DIR__ . '/data/bug-3478.php'], []);
 	}
 
+	public function testBug3629(): void
+	{
+		if (!self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test require static reflection.');
+		}
+		$this->phpVersionId = PHP_VERSION_ID;
+		$this->analyse([__DIR__ . '/data/bug-3629.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-3629.php b/tests/PHPStan/Rules/Methods/data/bug-3629.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace Bug3629;
+
+class HelloWorld extends \Thread
+{
+	public function start(int $options = PTHREADS_INHERIT_ALL)
+	{
+		return parent::start($options);
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -342,4 +342,13 @@ public function testBug3478(): void`
`342`	`342`	`$this->analyse([__DIR__ . '/data/bug-3478.php'], []);`
`343`	`343`	`}`
`344`	`344`
	`345`	`+ public function testBug3629(): void`
	`346`	`+ {`
	`347`	`+ if (!self::$useStaticReflectionProvider) {`
	`348`	`+ $this->markTestSkipped('Test require static reflection.');`
	`349`	`+ }`
	`350`	`+ $this->phpVersionId = PHP_VERSION_ID;`
	`351`	`+ $this->analyse([__DIR__ . '/data/bug-3629.php'], []);`
	`352`	`+ }`
	`353`	`+`
`345`	`354`	`}`