NullCoalesceRule - test that nothing is reported on nullsafe operator

ondrejmirtes · ondrejmirtes · commit c3bb2c46ad5a · 2020-11-12T09:49:00.000+01:00
diff --git a/tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php b/tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php
@@ -145,4 +145,13 @@ public function testCoalesceAssignRule(): void
 		]);
 	}
 
+	public function testNullsafe(): void
+	{
+		if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires PHP 8.0.');
+		}
+
+		$this->analyse([__DIR__ . '/data/null-coalesce-nullsafe.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Variables/data/null-coalesce-nullsafe.php b/tests/PHPStan/Rules/Variables/data/null-coalesce-nullsafe.php
@@ -0,0 +1,19 @@
+<?php // lint >= 8.0
+
+namespace NullCoalesceNullsafe;
+
+class Foo
+{
+
+	public function doFoo(
+		$mixed,
+		\Exception $nonNullable,
+		?\Exception $nullable
+	)
+	{
+		$mixed?->foo;
+		$nonNullable?->foo;
+		$nullable?->foo;
+	}
+
+}

Original file line number	Diff line number	Diff line change
`@@ -145,4 +145,13 @@ public function testCoalesceAssignRule(): void`
`145`	`145`	`]);`
`146`	`146`	`}`
`147`	`147`
	`148`	`+ public function testNullsafe(): void`
	`149`	`+ {`
	`150`	`+ if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {`
	`151`	`+ $this->markTestSkipped('Test requires PHP 8.0.');`
	`152`	`+ }`
	`153`	`+`
	`154`	`+ $this->analyse([__DIR__ . '/data/null-coalesce-nullsafe.php'], []);`
	`155`	`+ }`
	`156`	`+`
`148`	`157`	`}`