Only consider class-strings when resolving dependencies

ondrejmirtes · ondrejmirtes · commit b537b9757e7d · 2020-06-14T13:25:29.000+02:00
diff --git a/src/Dependency/DependencyResolver.php b/src/Dependency/DependencyResolver.php
@@ -15,6 +15,7 @@
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Reflection\ReflectionWithFilename;
 use PHPStan\Type\ClosureType;
+use PHPStan\Type\Constant\ConstantStringType;
 
 class DependencyResolver
 {
@@ -172,7 +173,10 @@ public function resolveDependencies(\PhpParser\Node $node, Scope $scope): array
 			foreach ($exprType->getIterableValueType()->getReferencedClasses() as $referencedClass) {
 				$this->addClassToDependencies($referencedClass, $dependenciesReflections);
 			}
-		} elseif ($node instanceof Array_) {
+		} elseif (
+			$node instanceof Array_
+			&& $this->considerArrayForCallableTest($scope, $node)
+		) {
 			$arrayType = $scope->getType($node);
 			if (!$arrayType->isCallable()->no()) {
 				foreach ($arrayType->getCallableParametersAcceptors($scope) as $variant) {
@@ -187,6 +191,20 @@ public function resolveDependencies(\PhpParser\Node $node, Scope $scope): array
 		return $dependenciesReflections;
 	}
 
+	private function considerArrayForCallableTest(Scope $scope, Array_ $arrayNode): bool
+	{
+		if (!isset($arrayNode->items[0])) {
+			return false;
+		}
+
+		$itemType = $scope->getType($arrayNode->items[0]->value);
+		if (!$itemType instanceof ConstantStringType) {
+			return true;
+		}
+
+		return $itemType->isClassString();
+	}
+
 	/**
 	 * @param string $className
 	 * @param ReflectionWithFilename[] $dependenciesReflections
diff --git a/src/Type/Constant/ConstantStringType.php b/src/Type/Constant/ConstantStringType.php
@@ -45,6 +45,11 @@ public function getValue(): string
 		return $this->value;
 	}
 
+	public function isClassString(): bool
+	{
+		return $this->isClassString;
+	}
+
 	public function describe(VerbosityLevel $level): string
 	{
 		return $level->handle(

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,11 @@ public function getValue(): string`
`45`	`45`	`return $this->value;`
`46`	`46`	`}`
`47`	`47`
	`48`	`+ public function isClassString(): bool`
	`49`	`+ {`
	`50`	`+ return $this->isClassString;`
	`51`	`+ }`
	`52`	`+`
`48`	`53`	`public function describe(VerbosityLevel $level): string`
`49`	`54`	`{`
`50`	`55`	`return $level->handle(`