Do not use Composer\InstalledVersions to parse PHPStan version

ondrejmirtes · ondrejmirtes · commit acbb55baeeb2 · 2022-10-06T13:51:16.000+02:00
diff --git a/src/Internal/ComposerHelper.php b/src/Internal/ComposerHelper.php
@@ -2,7 +2,6 @@
 
 namespace PHPStan\Internal;
 
-use Composer\InstalledVersions;
 use Nette\Utils\Json;
 use Nette\Utils\JsonException;
 use PHPStan\File\CouldNotReadFileException;
@@ -18,6 +17,8 @@
 final class ComposerHelper
 {
 
+	private static ?string $phpstanVersion = null;
+
 	/** @return array<string, mixed> */
 	public static function getComposerConfig(string $root): ?array
 	{
@@ -57,14 +58,22 @@ public static function getVendorDirFromComposerConfig(string $root, array $compo
 
 	public static function getPhpStanVersion(): string
 	{
-		$rootPackage = InstalledVersions::getRootPackage();
+		if (self::$phpstanVersion !== null) {
+			return self::$phpstanVersion;
+		}
+
+		$installed = require __DIR__ . '/../../vendor/composer/installed.php';
+		$rootPackage = $installed['root'] ?? null;
+		if ($rootPackage === null) {
+			return self::$phpstanVersion = 'Unknown version';
+		}
 
 		if (preg_match('/[^v\d.]/', $rootPackage['pretty_version']) === 0) {
 			// Handles tagged versions, see https://github.com/Jean85/pretty-package-versions/blob/2.0.5/src/Version.php#L31
-			return $rootPackage['pretty_version'];
+			return self::$phpstanVersion = $rootPackage['pretty_version'];
 		}
 
-		return $rootPackage['pretty_version'] . '@' . substr((string) $rootPackage['reference'], 0, 7);
+		return self::$phpstanVersion = $rootPackage['pretty_version'] . '@' . substr((string) $rootPackage['reference'], 0, 7);
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`
`3`	`3`	`namespace PHPStan\Internal;`
`4`	`4`
`5`		`-use Composer\InstalledVersions;`
`6`	`5`	`use Nette\Utils\Json;`
`7`	`6`	`use Nette\Utils\JsonException;`
`8`	`7`	`use PHPStan\File\CouldNotReadFileException;`
`@@ -18,6 +17,8 @@`
`18`	`17`	`final class ComposerHelper`
`19`	`18`	`{`
`20`	`19`
	`20`	`+ private static ?string $phpstanVersion = null;`
	`21`	`+`
`21`	`22`	`/** @return array<string, mixed> */`
`22`	`23`	`public static function getComposerConfig(string $root): ?array`
`23`	`24`	`{`
`@@ -57,14 +58,22 @@ public static function getVendorDirFromComposerConfig(string $root, array $compo`
`57`	`58`
`58`	`59`	`public static function getPhpStanVersion(): string`
`59`	`60`	`{`
`60`		`- $rootPackage = InstalledVersions::getRootPackage();`
	`61`	`+ if (self::$phpstanVersion !== null) {`
	`62`	`+ return self::$phpstanVersion;`
	`63`	`+ }`
	`64`	`+`
	`65`	`+ $installed = require __DIR__ . '/../../vendor/composer/installed.php';`
	`66`	`+ $rootPackage = $installed['root'] ?? null;`
	`67`	`+ if ($rootPackage === null) {`
	`68`	`+ return self::$phpstanVersion = 'Unknown version';`
	`69`	`+ }`
`61`	`70`
`62`	`71`	`if (preg_match('/[^v\d.]/', $rootPackage['pretty_version']) === 0) {`
`63`	`72`	`// Handles tagged versions, see https://github.com/Jean85/pretty-package-versions/blob/2.0.5/src/Version.php#L31`
`64`		`- return $rootPackage['pretty_version'];`
	`73`	`+ return self::$phpstanVersion = $rootPackage['pretty_version'];`
`65`	`74`	`}`
`66`	`75`
`67`		`- return $rootPackage['pretty_version'] . '@' . substr((string) $rootPackage['reference'], 0, 7);`
	`76`	`+ return self::$phpstanVersion = $rootPackage['pretty_version'] . '@' . substr((string) $rootPackage['reference'], 0, 7);`
`68`	`77`	`}`
`69`	`78`
`70`	`79`	`}`