SchedulerTest - easier assert

ondrejmirtes · ondrejmirtes · commit a98b908fb4dd · 2020-02-16T14:10:53.000+01:00
diff --git a/tests/PHPStan/Parallel/SchedulerTest.php b/tests/PHPStan/Parallel/SchedulerTest.php
@@ -55,11 +55,10 @@ public function testSchedule(
 		$schedule = $scheduler->scheduleWork($cpuCores, $files);
 
 		$this->assertSame($expectedNumberOfProcesses, $schedule->getNumberOfProcesses());
-		$this->assertCount(count($expectedJobSizes), $schedule->getJobs());
-		foreach ($expectedJobSizes as $i => $expectedJobSize) {
-			$scheduledJob = $schedule->getJobs()[$i];
-			$this->assertCount($expectedJobSize, $scheduledJob);
-		}
+		$jobSizes = array_map(static function (array $job): int {
+			return count($job);
+		}, $schedule->getJobs());
+		$this->assertSame($expectedJobSizes, $jobSizes);
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -55,11 +55,10 @@ public function testSchedule(`
`55`	`55`	`$schedule = $scheduler->scheduleWork($cpuCores, $files);`
`56`	`56`
`57`	`57`	`$this->assertSame($expectedNumberOfProcesses, $schedule->getNumberOfProcesses());`
`58`		`- $this->assertCount(count($expectedJobSizes), $schedule->getJobs());`
`59`		`- foreach ($expectedJobSizes as $i => $expectedJobSize) {`
`60`		`- $scheduledJob = $schedule->getJobs()[$i];`
`61`		`- $this->assertCount($expectedJobSize, $scheduledJob);`
`62`		`- }`
	`58`	`+ $jobSizes = array_map(static function (array $job): int {`
	`59`	`+ return count($job);`
	`60`	`+ }, $schedule->getJobs());`
	`61`	`+ $this->assertSame($expectedJobSizes, $jobSizes);`
`63`	`62`	`}`
`64`	`63`
`65`	`64`	`}`