numeric-string in array leads to integer key type

ondrejmirtes · ondrejmirtes · commit a74a3008aacd · 2020-08-25T17:10:10.000+02:00
diff --git a/src/Type/ArrayType.php b/src/Type/ArrayType.php
@@ -296,7 +296,7 @@ public static function castToArrayKeyType(Type $offsetType): Type
 				return $offsetType;
 			}
 
-			if ($offsetType instanceof FloatType || $offsetType instanceof BooleanType) {
+			if ($offsetType instanceof FloatType || $offsetType instanceof BooleanType || $offsetType->isNumericString()->yes()) {
 				return new IntegerType();
 			}
 
diff --git a/tests/PHPStan/Analyser/data/bug-3133.php b/tests/PHPStan/Analyser/data/bug-3133.php
@@ -43,4 +43,16 @@ public function doBaz(
 		assertType('string&numeric', $numericString);
 	}
 
+	/**
+	 * @param numeric-string $numericString
+	 */
+	public function doLorem(
+		string $numericString
+	)
+	{
+		$a = [];
+		$a[$numericString] = 'foo';
+		assertType('array<int, \'foo\'>', $a);
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ public static function castToArrayKeyType(Type $offsetType): Type`
`296`	`296`	`return $offsetType;`
`297`	`297`	`}`
`298`	`298`
`299`		`- if ($offsetType instanceof FloatType \|\| $offsetType instanceof BooleanType) {`
	`299`	`+ if ($offsetType instanceof FloatType \|\| $offsetType instanceof BooleanType \|\| $offsetType->isNumericString()->yes()) {`
`300`	`300`	`return new IntegerType();`
`301`	`301`	`}`
`302`	`302`