Make phpunit fail if a --filter does not execute any tests (#2924)

staabm · web-flow · commit a018f1ebe040 · 2024-02-18T12:53:21.000+01:00
diff --git a/phpunit.xml b/phpunit.xml
@@ -4,8 +4,10 @@
 	bootstrap="tests/bootstrap.php"
 	cacheResult="false"
 	colors="true"
+	executionOrder="random"
 	failOnRisky="true"
 	failOnWarning="true"
+	failOnEmptyTestSuite="true"
 	beStrictAboutChangesToGlobalState="true"
 	beStrictAboutCoversAnnotation="true"
 	beStrictAboutOutputDuringTests="true"
diff --git a/tests/PHPStan/Command/ErrorFormatter/TableErrorFormatterTest.php b/tests/PHPStan/Command/ErrorFormatter/TableErrorFormatterTest.php
@@ -24,6 +24,7 @@ protected function setUp(): void
 	protected function tearDown(): void
 	{
 		putenv('COLUMNS');
+		putenv('TERM_PROGRAM');
 	}
 
 	public function dataFormatterOutputProvider(): iterable
@@ -195,6 +196,7 @@ public function testFormatErrors(
 		}
 		$formatter = $this->createErrorFormatter(null);
 
+		// NOTE: extra env vars need to be cleared in tearDown()
 		foreach ($extraEnvVars as $envVar) {
 			putenv($envVar);
 		}

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ protected function setUp(): void`
`24`	`24`	`protected function tearDown(): void`
`25`	`25`	`{`
`26`	`26`	`putenv('COLUMNS');`
	`27`	`+ putenv('TERM_PROGRAM');`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`public function dataFormatterOutputProvider(): iterable`
`@@ -195,6 +196,7 @@ public function testFormatErrors(`
`195`	`196`	`}`
`196`	`197`	`$formatter = $this->createErrorFormatter(null);`
`197`	`198`
	`199`	`+ // NOTE: extra env vars need to be cleared in tearDown()`
`198`	`200`	`foreach ($extraEnvVars as $envVar) {`
`199`	`201`	`putenv($envVar);`
`200`	`202`	`}`