Fix native union type parameter with false

ondrejmirtes · ondrejmirtes · commit 917cdb13748c · 2020-10-07T23:30:55.000+02:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -2736,6 +2736,8 @@ public function getFunctionType($type, bool $isNullable, bool $isVariadic): Type
 			return new VoidType();
 		} elseif ($type === 'object') {
 			return new ObjectWithoutClassType();
+		} elseif ($type === 'false') {
+			return new ConstantBooleanType(false);
 		} elseif ($type === 'mixed') {
 			return new MixedType(true);
 		}
diff --git a/tests/PHPStan/Reflection/data/unionTypes.php b/tests/PHPStan/Reflection/data/unionTypes.php
@@ -43,3 +43,20 @@ function (): void {
 
 	assertType('NativeUnionTypes\\Bar|NativeUnionTypes\\Foo', $f(1));
 };
+
+class Baz
+{
+
+	public function doFoo(array|false $foo): void
+	{
+		assertType('array|false', $foo);
+		assertNativeType('array|false', $foo);
+		assertType('array|false', $this->doBar());
+	}
+
+	public function doBar(): array|false
+	{
+
+	}
+
+}

Original file line number	Diff line number	Diff line change
`@@ -2736,6 +2736,8 @@ public function getFunctionType($type, bool $isNullable, bool $isVariadic): Type`
`2736`	`2736`	`return new VoidType();`
`2737`	`2737`	`} elseif ($type === 'object') {`
`2738`	`2738`	`return new ObjectWithoutClassType();`
	`2739`	`+ } elseif ($type === 'false') {`
	`2740`	`+ return new ConstantBooleanType(false);`
`2739`	`2741`	`} elseif ($type === 'mixed') {`
`2740`	`2742`	`return new MixedType(true);`
`2741`	`2743`	`}`