Documentation URL showed with autoloading errors

ondrejmirtes · ondrejmirtes · commit 836d227f0ee8 · 2020-04-11T13:29:44.000+02:00
diff --git a/src/AnalysedCodeException.php b/src/AnalysedCodeException.php
@@ -5,4 +5,6 @@
 abstract class AnalysedCodeException extends \Exception
 {
 
+	abstract public function getTip(): ?string;
+
 }
diff --git a/src/Analyser/FileAnalyser.php b/src/Analyser/FileAnalyser.php
@@ -82,7 +82,7 @@ public function analyseFile(
 							}
 
 							$uniquedAnalysedCodeExceptionMessages[$e->getMessage()] = true;
-							$fileErrors[] = new Error($e->getMessage(), $file, $node->getLine(), false);
+							$fileErrors[] = new Error($e->getMessage(), $file, $node->getLine(), false, null, null, $e->getTip());
 							continue;
 						} catch (IdentifierNotFound $e) {
 							$fileErrors[] = new Error(sprintf('Reflection error: %s not found.', $e->getIdentifier()->getName()), $file, $node->getLine(), false);
@@ -176,7 +176,7 @@ public function analyseFile(
 					$fileErrors[] = new Error($error->getMessage(), $file, $error->getStartLine() !== -1 ? $error->getStartLine() : null, false);
 				}
 			} catch (\PHPStan\AnalysedCodeException $e) {
-				$fileErrors[] = new Error($e->getMessage(), $file, null, false);
+				$fileErrors[] = new Error($e->getMessage(), $file, null, false, null, null, $e->getTip());
 			} catch (IdentifierNotFound $e) {
 				$fileErrors[] = new Error(sprintf('Reflection error: %s not found.', $e->getIdentifier()->getName()), $file, null, false);
 			}
diff --git a/src/Analyser/UndefinedVariableException.php b/src/Analyser/UndefinedVariableException.php
@@ -28,4 +28,9 @@ public function getVariableName(): string
 		return $this->variableName;
 	}
 
+	public function getTip(): ?string
+	{
+		return null;
+	}
+
 }
diff --git a/src/Broker/ClassAutoloadingException.php b/src/Broker/ClassAutoloadingException.php
@@ -35,4 +35,9 @@ public function getClassName(): string
 		return $this->className;
 	}
 
+	public function getTip(): ?string
+	{
+		return 'Learn more at https://phpstan.org/user-guide/autoloading';
+	}
+
 }
diff --git a/src/Broker/ClassNotFoundException.php b/src/Broker/ClassNotFoundException.php
@@ -19,4 +19,9 @@ public function getClassName(): string
 		return $this->className;
 	}
 
+	public function getTip(): ?string
+	{
+		return 'Learn more at https://phpstan.org/user-guide/autoloading';
+	}
+
 }
diff --git a/src/Broker/ConstantNotFoundException.php b/src/Broker/ConstantNotFoundException.php
@@ -19,4 +19,9 @@ public function getConstantName(): string
 		return $this->constantName;
 	}
 
+	public function getTip(): ?string
+	{
+		return 'Learn more at https://phpstan.org/user-guide/autoloading';
+	}
+
 }
diff --git a/src/Broker/FunctionNotFoundException.php b/src/Broker/FunctionNotFoundException.php
@@ -19,4 +19,9 @@ public function getFunctionName(): string
 		return $this->functionName;
 	}
 
+	public function getTip(): ?string
+	{
+		return 'Learn more at https://phpstan.org/user-guide/autoloading';
+	}
+
 }
diff --git a/src/File/CouldNotReadFileException.php b/src/File/CouldNotReadFileException.php
@@ -10,4 +10,9 @@ public function __construct(string $fileName)
 		parent::__construct(sprintf('Could not read file: %s', $fileName));
 	}
 
+	public function getTip(): ?string
+	{
+		return null;
+	}
+
 }
diff --git a/src/File/CouldNotWriteFileException.php b/src/File/CouldNotWriteFileException.php
@@ -10,4 +10,9 @@ public function __construct(string $fileName, string $error)
 		parent::__construct(sprintf('Could not write file: %s (%s)', $fileName, $error));
 	}
 
+	public function getTip(): ?string
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/MissingConstantFromReflectionException.php b/src/Reflection/MissingConstantFromReflectionException.php
@@ -23,4 +23,9 @@ public function __construct(
 		);
 	}
 
+	public function getTip(): ?string
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/MissingMethodFromReflectionException.php b/src/Reflection/MissingMethodFromReflectionException.php
@@ -23,4 +23,9 @@ public function __construct(
 		);
 	}
 
+	public function getTip(): ?string
+	{
+		return null;
+	}
+
 }
diff --git a/src/Reflection/MissingPropertyFromReflectionException.php b/src/Reflection/MissingPropertyFromReflectionException.php
@@ -23,4 +23,9 @@ public function __construct(
 		);
 	}
 
+	public function getTip(): ?string
+	{
+		return null;
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -5,4 +5,6 @@`
`5`	`5`	`abstract class AnalysedCodeException extends \Exception`
`6`	`6`	`{`
`7`	`7`
	`8`	`+ abstract public function getTip(): ?string;`
	`9`	`+`
`8`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function analyseFile(`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`$uniquedAnalysedCodeExceptionMessages[$e->getMessage()] = true;`
`85`		`- $fileErrors[] = new Error($e->getMessage(), $file, $node->getLine(), false);`
	`85`	`+ $fileErrors[] = new Error($e->getMessage(), $file, $node->getLine(), false, null, null, $e->getTip());`
`86`	`86`	`continue;`
`87`	`87`	`} catch (IdentifierNotFound $e) {`
`88`	`88`	`$fileErrors[] = new Error(sprintf('Reflection error: %s not found.', $e->getIdentifier()->getName()), $file, $node->getLine(), false);`
`@@ -176,7 +176,7 @@ public function analyseFile(`
`176`	`176`	`$fileErrors[] = new Error($error->getMessage(), $file, $error->getStartLine() !== -1 ? $error->getStartLine() : null, false);`
`177`	`177`	`}`
`178`	`178`	`} catch (\PHPStan\AnalysedCodeException $e) {`
`179`		`- $fileErrors[] = new Error($e->getMessage(), $file, null, false);`
	`179`	`+ $fileErrors[] = new Error($e->getMessage(), $file, null, false, null, null, $e->getTip());`
`180`	`180`	`} catch (IdentifierNotFound $e) {`
`181`	`181`	`$fileErrors[] = new Error(sprintf('Reflection error: %s not found.', $e->getIdentifier()->getName()), $file, null, false);`
`182`	`182`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,4 +28,9 @@ public function getVariableName(): string`
`28`	`28`	`return $this->variableName;`
`29`	`29`	`}`
`30`	`30`
	`31`	`+ public function getTip(): ?string`
	`32`	`+ {`
	`33`	`+ return null;`
	`34`	`+ }`
	`35`	`+`
`31`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,4 +35,9 @@ public function getClassName(): string`
`35`	`35`	`return $this->className;`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ public function getTip(): ?string`
	`39`	`+ {`
	`40`	`+ return 'Learn more at https://phpstan.org/user-guide/autoloading';`
	`41`	`+ }`
	`42`	`+`
`38`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,4 +19,9 @@ public function getClassName(): string`
`19`	`19`	`return $this->className;`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ public function getTip(): ?string`
	`23`	`+ {`
	`24`	`+ return 'Learn more at https://phpstan.org/user-guide/autoloading';`
	`25`	`+ }`
	`26`	`+`
`22`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,4 +19,9 @@ public function getConstantName(): string`
`19`	`19`	`return $this->constantName;`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ public function getTip(): ?string`
	`23`	`+ {`
	`24`	`+ return 'Learn more at https://phpstan.org/user-guide/autoloading';`
	`25`	`+ }`
	`26`	`+`
`22`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,4 +19,9 @@ public function getFunctionName(): string`
`19`	`19`	`return $this->functionName;`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ public function getTip(): ?string`
	`23`	`+ {`
	`24`	`+ return 'Learn more at https://phpstan.org/user-guide/autoloading';`
	`25`	`+ }`
	`26`	`+`
`22`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,9 @@ public function __construct(string $fileName)`
`10`	`10`	`parent::__construct(sprintf('Could not read file: %s', $fileName));`
`11`	`11`	`}`
`12`	`12`
	`13`	`+ public function getTip(): ?string`
	`14`	`+ {`
	`15`	`+ return null;`
	`16`	`+ }`
	`17`	`+`
`13`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,4 +23,9 @@ public function __construct(`
`23`	`23`	`);`
`24`	`24`	`}`
`25`	`25`
	`26`	`+ public function getTip(): ?string`
	`27`	`+ {`
	`28`	`+ return null;`
	`29`	`+ }`
	`30`	`+`
`26`	`31`	`}`