Cleanup thanks to maybe certainty for variables in root scope

ondrejmirtes · ondrejmirtes · commit 7ea7ce4994f9 · 2020-06-20T14:16:58.000+02:00
diff --git a/src/Rules/PhpDoc/WrongVariableNameInVarTagRule.php b/src/Rules/PhpDoc/WrongVariableNameInVarTagRule.php
@@ -281,10 +281,6 @@ private function processStmt(Scope $scope, array $varTags, ?Expr $defaultExpr):
 				continue;
 			}
 
-			if ($scope->getFunction() === null && !$scope->isInAnonymousFunction()) {
-				continue;
-			}
-
 			$errors[] = RuleErrorBuilder::message(sprintf('Variable $%s in PHPDoc tag @var does not exist.', $name))->build();
 		}
 
diff --git a/src/Rules/Variables/VariableCertaintyNullCoalesceRule.php b/src/Rules/Variables/VariableCertaintyNullCoalesceRule.php
@@ -53,16 +53,11 @@ public function processNode(Node $node, Scope $scope): array
 
 		$certainty = $scope->hasVariableType($var->name);
 		if ($certainty->no()) {
-			if (
-				$scope->getFunction() !== null
-				|| $scope->isInAnonymousFunction()
-			) {
-				return [RuleErrorBuilder::message(sprintf(
-					'Variable $%s on left side of %s is never defined.',
-					$var->name,
-					$description
-				))->build()];
-			}
+			return [RuleErrorBuilder::message(sprintf(
+				'Variable $%s on left side of %s is never defined.',
+				$var->name,
+				$description
+			))->build()];
 		} elseif ($certainty->yes() && !$isSubNode) {
 			$variableType = $scope->getVariableType($var->name);
 			if ($variableType->isSuperTypeOf(new NullType())->no()) {

Original file line number	Diff line number	Diff line change
`@@ -281,10 +281,6 @@ private function processStmt(Scope $scope, array $varTags, ?Expr $defaultExpr):`
`281`	`281`	`continue;`
`282`	`282`	`}`
`283`	`283`
`284`		`- if ($scope->getFunction() === null && !$scope->isInAnonymousFunction()) {`
`285`		`- continue;`
`286`		`- }`
`287`		`-`
`288`	`284`	`$errors[] = RuleErrorBuilder::message(sprintf('Variable $%s in PHPDoc tag @var does not exist.', $name))->build();`
`289`	`285`	`}`
`290`	`286`