Fix callable parameter checking for Stringable objects in non-strict mode

ondrejmirtes · staabm · commit 6938ec56160d · 2026-03-26T15:13:04.000+01:00
- Propagated $strictTypes from CallableType::accepts() through to CallableTypeHelper - In non-strict mode, Stringable objects are now accepted where string is expected in callable parameters - This fixes false positives for patterns like uasort($stringableArray, 'strnatcasecmp') - In strict_types mode, the stricter behavior is preserved (e.g. closures with explicit string params) - New regression test in tests/PHPStan/Rules/Functions/data/bug-11619.php Closes phpstan/phpstan#11619
diff --git a/src/Type/CallableType.php b/src/Type/CallableType.php
@@ -139,7 +139,7 @@ public function accepts(Type $type, bool $strictTypes): AcceptsResult
 			return $type->isAcceptedBy($this, $strictTypes);
 		}
 
-		return $this->isSuperTypeOfInternal($type, true)->toAcceptsResult();
+		return $this->isSuperTypeOfInternal($type, true, $strictTypes)->toAcceptsResult();
 	}
 
 	public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
@@ -148,10 +148,10 @@ public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
 			return $type->isSubTypeOf($this);
 		}
 
-		return $this->isSuperTypeOfInternal($type, false);
+		return $this->isSuperTypeOfInternal($type, false, true);
 	}
 
-	private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny): IsSuperTypeOfResult
+	private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny, bool $strictTypes): IsSuperTypeOfResult
 	{
 		$isCallable = new IsSuperTypeOfResult($type->isCallable(), []);
 		if ($isCallable->no()) {
@@ -184,7 +184,7 @@ private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny): IsSup
 			if (!$variant instanceof CallableParametersAcceptor) {
 				return IsSuperTypeOfResult::createNo([]);
 			}
-			$isSuperType = CallableTypeHelper::isParametersAcceptorSuperTypeOf($this, $variant, $treatMixedAsAny);
+			$isSuperType = CallableTypeHelper::isParametersAcceptorSuperTypeOf($this, $variant, $treatMixedAsAny, $strictTypes);
 			if ($variantsResult === null) {
 				$variantsResult = $isSuperType;
 			} else {
diff --git a/src/Type/CallableTypeHelper.php b/src/Type/CallableTypeHelper.php
@@ -16,6 +16,7 @@ public static function isParametersAcceptorSuperTypeOf(
 		CallableParametersAcceptor $ours,
 		CallableParametersAcceptor $theirs,
 		bool $treatMixedAsAny,
+		bool $strictTypes = true,
 	): IsSuperTypeOfResult
 	{
 		$theirParameters = $theirs->getParameters();
@@ -72,7 +73,7 @@ public static function isParametersAcceptorSuperTypeOf(
 			}
 
 			if ($treatMixedAsAny) {
-				$isSuperType = $theirParameter->getType()->accepts($ourParameterType, true);
+				$isSuperType = $theirParameter->getType()->accepts($ourParameterType, $strictTypes);
 				$isSuperType = new IsSuperTypeOfResult($isSuperType->result, $isSuperType->reasons);
 			} else {
 				$isSuperType = $theirParameter->getType()->isSuperTypeOf($ourParameterType);
diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -2741,6 +2741,12 @@ public function testBug12363(): void
 		$this->analyse([__DIR__ . '/data/bug-12363.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.1')]
+	public function testBug11619(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11619.php'], []);
+	}
+
 	public function testBug13247(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-13247.php'], []);
diff --git a/tests/PHPStan/Rules/Functions/data/bug-11619.php b/tests/PHPStan/Rules/Functions/data/bug-11619.php
@@ -0,0 +1,30 @@
+<?php // lint >= 8.1
+
+namespace Bug11619;
+
+final class Foo implements \Stringable {
+
+	private function __construct(public readonly string $value) {
+	}
+
+	public static function fromString(string $string): self {
+		return new self($string);
+	}
+
+	public function __toString(): string {
+		return $this->value;
+	}
+
+}
+
+function test(): void
+{
+	$options = [
+		Foo::fromString('c'),
+		Foo::fromString('b'),
+		Foo::fromString('a'),
+	];
+
+	uasort($options, 'strnatcasecmp');
+	usort($options, 'strnatcasecmp');
+}

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function accepts(Type $type, bool $strictTypes): AcceptsResult`
`139`	`139`	`return $type->isAcceptedBy($this, $strictTypes);`
`140`	`140`	`}`
`141`	`141`
`142`		`- return $this->isSuperTypeOfInternal($type, true)->toAcceptsResult();`
	`142`	`+ return $this->isSuperTypeOfInternal($type, true, $strictTypes)->toAcceptsResult();`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`public function isSuperTypeOf(Type $type): IsSuperTypeOfResult`
`@@ -148,10 +148,10 @@ public function isSuperTypeOf(Type $type): IsSuperTypeOfResult`
`148`	`148`	`return $type->isSubTypeOf($this);`
`149`	`149`	`}`
`150`	`150`
`151`		`- return $this->isSuperTypeOfInternal($type, false);`
	`151`	`+ return $this->isSuperTypeOfInternal($type, false, true);`
`152`	`152`	`}`
`153`	`153`
`154`		`- private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny): IsSuperTypeOfResult`
	`154`	`+ private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny, bool $strictTypes): IsSuperTypeOfResult`
`155`	`155`	`{`
`156`	`156`	`$isCallable = new IsSuperTypeOfResult($type->isCallable(), []);`
`157`	`157`	`if ($isCallable->no()) {`
`@@ -184,7 +184,7 @@ private function isSuperTypeOfInternal(Type $type, bool $treatMixedAsAny): IsSup`
`184`	`184`	`if (!$variant instanceof CallableParametersAcceptor) {`
`185`	`185`	`return IsSuperTypeOfResult::createNo([]);`
`186`	`186`	`}`
`187`		`- $isSuperType = CallableTypeHelper::isParametersAcceptorSuperTypeOf($this, $variant, $treatMixedAsAny);`
	`187`	`+ $isSuperType = CallableTypeHelper::isParametersAcceptorSuperTypeOf($this, $variant, $treatMixedAsAny, $strictTypes);`
`188`	`188`	`if ($variantsResult === null) {`
`189`	`189`	`$variantsResult = $isSuperType;`
`190`	`190`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -2741,6 +2741,12 @@ public function testBug12363(): void`
`2741`	`2741`	`$this->analyse([__DIR__ . '/data/bug-12363.php'], []);`
`2742`	`2742`	`}`
`2743`	`2743`
	`2744`	`+ #[RequiresPhp('>= 8.1')]`
	`2745`	`+ public function testBug11619(): void`
	`2746`	`+ {`
	`2747`	`+ $this->analyse([__DIR__ . '/data/bug-11619.php'], []);`
	`2748`	`+ }`
	`2749`	`+`
`2744`	`2750`	`public function testBug13247(): void`
`2745`	`2751`	`{`
`2746`	`2752`	`$this->analyse([__DIR__ . '/data/bug-13247.php'], []);`