Fix overriden variadic parameter

ondrejmirtes · ondrejmirtes · commit 64618be1140e · 2020-06-07T13:19:43.000+02:00
diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -151,7 +151,7 @@ private function getParameters(): array
 			}
 			$parameters[] = new PhpParameterFromParserNodeReflection(
 				$parameter->var->name,
-				$isOptional,
+				$isOptional || $parameter->variadic,
 				$this->realParameterTypes[$parameter->var->name],
 				$this->phpDocParameterTypes[$parameter->var->name] ?? null,
 				$parameter->byRef
diff --git a/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php b/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php
@@ -5,6 +5,7 @@
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<OverridingMethodRule>
@@ -313,4 +314,10 @@ public function testParle(int $phpVersion, string $contravariantMessage, string
 		]);
 	}
 
+	public function testVariadicParameterIsAlwaysOptional(): void
+	{
+		$this->phpVersionId = PHP_VERSION_ID;
+		$this->analyse([__DIR__ . '/data/variadic-always-optional.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/variadic-always-optional.php b/tests/PHPStan/Rules/Methods/data/variadic-always-optional.php
@@ -0,0 +1,33 @@
+<?php
+
+namespace VariadicParameterAlwaysOptional;
+
+class Foo
+{
+
+	public function doFoo(string ...$test): void
+	{
+
+	}
+
+	public function doBar(): void
+	{
+
+	}
+
+}
+
+class Bar extends Foo
+{
+
+	public function doFoo(string ...$test): void
+	{
+
+	}
+
+	public function doBar(...$test): void
+	{
+
+	}
+
+}

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ private function getParameters(): array`
`151`	`151`	`}`
`152`	`152`	`$parameters[] = new PhpParameterFromParserNodeReflection(`
`153`	`153`	`$parameter->var->name,`
`154`		`- $isOptional,`
	`154`	`+ $isOptional \|\| $parameter->variadic,`
`155`	`155`	`$this->realParameterTypes[$parameter->var->name],`
`156`	`156`	`$this->phpDocParameterTypes[$parameter->var->name] ?? null,`
`157`	`157`	`$parameter->byRef`