YUUUUUUUGE performance improvement for full analysis with heavily populated cache

dktapps · dktapps · commit 5b784ad1019e · 2021-10-24T20:48:19.000+01:00
this change reduces full analysis time of pmmp/PocketMine-MP from 33sec to 13sec (no result cache)
diff --git a/src/Command/CommandHelper.php b/src/Command/CommandHelper.php
@@ -48,7 +48,8 @@ public static function begin(
 		bool $manageMemoryLimitFile = true,
 		bool $debugEnabled = false,
 		?string $singleReflectionFile = null,
-		?string $singleReflectionInsteadOfFile = null
+		?string $singleReflectionInsteadOfFile = null,
+		bool $cleanupContainerCache = true
 	): InceptionResult
 	{
 		if (!$allowXdebug) {
@@ -257,7 +258,9 @@ public static function begin(
 			throw new \PHPStan\Command\InceptionNotSuccessfulException();
 		}
 
-		$containerFactory->clearOldContainers($tmpDir);
+		if ($cleanupContainerCache) {
+			$containerFactory->clearOldContainers($tmpDir);
+		}
 
 		if (count($paths) === 0) {
 			$errorOutput->writeLineFormatted('At least one path must be specified to analyse.');
diff --git a/src/Command/WorkerCommand.php b/src/Command/WorkerCommand.php
@@ -111,7 +111,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 				$allowXdebug,
 				false,
 				false,
-				$singleReflectionFile
+				$singleReflectionFile,
+				null,
+				false
 			);
 		} catch (\PHPStan\Command\InceptionNotSuccessfulException $e) {
 			return 1;
