Fix array_filter callback return type

ondrejmirtes · ondrejmirtes · commit 59ae706f1333 · 2024-01-19T13:46:38.000+01:00
diff --git a/src/Reflection/ParametersAcceptorSelector.php b/src/Reflection/ParametersAcceptorSelector.php
@@ -176,7 +176,7 @@ public static function selectFromArgs(
 							$arrayFilterParameters ?? [
 								new DummyParameter('item', $scope->getIterableValueType($scope->getType($args[0]->value)), false, PassedByReference::createNo(), false, null),
 							],
-							new MixedType(),
+							new BooleanType(),
 							false,
 						),
 						new NullType(),
diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -868,13 +868,13 @@ public function testArrayFilterCallback(bool $checkExplicitMixed): void
 		$this->checkExplicitMixed = $checkExplicitMixed;
 		$errors = [
 			[
-				'Parameter #2 $callback of function array_filter expects (callable(int): mixed)|null, Closure(string): true given.',
+				'Parameter #2 $callback of function array_filter expects (callable(int): bool)|null, Closure(string): true given.',
 				17,
 			],
 		];
 		if ($checkExplicitMixed) {
 			$errors[] = [
-				'Parameter #2 $callback of function array_filter expects (callable(mixed): mixed)|null, Closure(int): true given.',
+				'Parameter #2 $callback of function array_filter expects (callable(mixed): bool)|null, Closure(int): true given.',
 				20,
 				'Type #1 from the union: Type int of parameter #1 $i of passed callable needs to be same or wider than parameter type mixed of accepting callable.',
 			];
@@ -1609,4 +1609,18 @@ public function testBug9697(): void
 		$this->analyse([__DIR__ . '/data/bug-9697.php'], []);
 	}
 
+	public function testDiscussion10454(): void
+	{
+		$this->analyse([__DIR__ . '/data/discussion-10454.php'], [
+			[
+				"Parameter #2 \$callback of function array_filter expects (callable('bar'|'baz'|'foo'|'quux'|'qux'): bool)|null, Closure(string): stdClass given.",
+				13,
+			],
+			[
+				"Parameter #2 \$callback of function array_filter expects (callable('bar'|'baz'|'foo'|'quux'|'qux'): bool)|null, Closure(string): stdClass given.",
+				23,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Functions/data/discussion-10454.php b/tests/PHPStan/Rules/Functions/data/discussion-10454.php
@@ -0,0 +1,29 @@
+<?php
+
+namespace Discussion10454;
+
+use stdClass;
+
+function (): void {
+	$arr = ['foo', 'bar', 'baz', 'qux', 'quux'];
+
+	print_r(
+		array_filter(
+			$arr,
+			function (string $foo): stdClass
+			{
+				return new stdClass();
+			}
+		)
+	);
+
+	print_r(
+		array_filter(
+			$arr,
+			function (string $foo)
+			{
+				return new stdClass();
+			}
+		)
+	);
+};
